gomod(deps): Update to sdk@487e048643d5 - #465
Open
jedevc wants to merge 1 commit into
Open
Conversation
NewHTTPClient now clones DefaultTransport, so clients pick up the 90s idle connection timeout and HTTP/2 instead of holding idle sockets open for the lifetime of the process. Signed-off-by: Justin Chadwell <justin@unikraft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up unikraft-cloud/go-sdk#256, so
NewHTTPClientclonesDefaultTransportrather than building a bare one — clients get the 90s idle connection timeout and HTTP/2 back instead of holding their idle sockets open for the lifetime of the process.Same bump as https://github.com/unikraft-cloud/console/pull/1109, which is where the fd exhaustion this fixes actually showed up.
The integration suite is red against staging, but
prod-stagingfails identically without this patch — same seven subtests, same causes:sched_priorityis rejected by the backend there, and the fiveunikraft buildtests 403 because the registry namespace is at 963 MiB of its 1.0 GiB limit../internal/builderis green either way.