Skip to content

fix: Catch up docs with the CLI flag renames - #261

Open
jedevc wants to merge 3 commits into
prod-stagingfrom
docs/parse-flag-renames
Open

fix: Catch up docs with the CLI flag renames#261
jedevc wants to merge 3 commits into
prod-stagingfrom
docs/parse-flag-renames

Conversation

@jedevc

@jedevc jedevc commented Aug 20, 2026

Copy link
Copy Markdown
Member

The CLI dropped csv-style parsing for lists and maps and renamed the plural flags, so --tags production,customer_A, --services, and --domains are all broken in the docs as they stand.

Breaking change: unikraft-cloud/cli#395

Also documents how to express a list or map field now that commas are gone—repeat the flag, or write JSON—which pages/cli/fields.mdx never covered at all.

The two template-creation examples on the tagging page turned out to be broken in a way the flag rename doesn't explain: neither POST /instances/templates nor POST /volumes/templates accepts tags at all, and both reject unknown members, so those API tabs would 400 as written. Templating relabels the source record in place, so the template already inherits the instance's or volume's tags — both blocks now tag the resource and then convert it.

@jedevc
jedevc temporarily deployed to pull-requests August 20, 2026 17:13 — with GitHub Actions Inactive
@github-actions
github-actions Bot temporarily deployed to pull-requests August 20, 2026 17:15 Inactive
@jedevc
jedevc temporarily deployed to pull-requests August 20, 2026 17:15 — with GitHub Actions Inactive
@github-actions
github-actions Bot temporarily deployed to pull-requests August 20, 2026 17:19 Inactive
Comment thread pages/platform/tagging.mdx Outdated
Comment thread pages/platform/tagging.mdx Outdated
jedevc added 3 commits August 24, 2026 13:59
The CLI renamed --tags to --tag and no longer splits a flag value on
commas, so every example here set a single tag literally named
"production,customer_A". Repeat the flag instead.

The two template examples were wrong in a second way: neither
/instances/templates nor /volumes/templates accepts tags, and both
reject unknown members, so the CLI has no field to expose and the API
calls as written would fail outright. Templating relabels the source
record in place rather than building a new one, so the template already
carries the instance's or volume's tags — tag the resource first, then
convert it. Left the CLI alone rather than adding a --tag flag the
platform has nothing to do with.

The trailing note about comma separation still holds for --filter and
the API query parameter, so it's scoped to filtering rather than
dropped.

Signed-off-by: Justin Chadwell <justin@unikraft.com>
Renamed in the CLI alongside --tags. Both already appeared as repeated
flags in these examples, so this is only the rename.

Signed-off-by: Justin Chadwell <justin@unikraft.com>
Nothing said how to express more than one element. Now that the CLI no
longer splits a flag value on commas, repeating the flag or writing JSON
are the only two ways, and neither was written down anywhere.

Signed-off-by: Justin Chadwell <justin@unikraft.com>
@jedevc
jedevc force-pushed the docs/parse-flag-renames branch from 9148bba to d95edd3 Compare August 24, 2026 13:00
@jedevc
jedevc temporarily deployed to pull-requests August 24, 2026 13:00 — with GitHub Actions Inactive
@jedevc
jedevc requested a review from nurof3n August 24, 2026 13:00
@github-actions
github-actions Bot temporarily deployed to pull-requests August 24, 2026 13:03 Inactive
@jedevc
jedevc marked this pull request as ready for review August 24, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants