feat: add limits for modifiers and dimensions#152
Open
feat: add limits for modifiers and dimensions#152
Conversation
Author
|
Taking into consideration the deployment issues of existing users and to avoid any breaking changes, the default values will retain all settings. By limiting the maximum pixels, potential damage caused by attacks can be minimized. |
atinux
reviewed
Jul 27, 2023
Codecov Report
@@ Coverage Diff @@
## main #152 +/- ##
==========================================
- Coverage 56.91% 56.39% -0.52%
==========================================
Files 10 10
Lines 940 977 +37
Branches 41 42 +1
==========================================
+ Hits 535 551 +16
- Misses 405 426 +21
|
Author
|
Is there any way I can continue to promote this PR? Because we're suffering from memory crashes due to mass production of images. |
Member
|
I guess until @pi0 can have a look at it, you can use your fork version @ausir0726 |
Contributor
|
I wonder if validating modifiers via a Joi, zod or typebox schema would be the better approach? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
π Linked issue
#45
β Type of change
π Description
Based on the issues mentioned, using encrypted URLs as a deterrent against abuse should be considered. However, inspired by Cloudinary's approach (where the server stops serving images beyond 8000px, which likely meets current screen usage), and taking into account the limitations on images in the ImageKit.io documentation, we have decided to impose restrictions on the usage of modifiers. Additionally, requests for width or height must conform to the maximum limits. This configuration serves as the minimum guarantee to prevent server abuse when URL encryption is not applied.
Furthermore, an example of using IPX_DOMAINS is added because it defaults to an empty array, but the input value is in the form of a comma-separated string, leading to confusion due to the different data types in use.
ImageKit.io doc about limits image : https://docs.imagekit.io/limits-and-troubleshooting/limits
π Checklist