Skip to content

[Refactor] Shared per-mesh vertex-stream binding helpers #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
untoldengine merged 2 commits into from
Aug 6, 2026
Merged

[Refactor] Shared per-mesh vertex-stream binding helpers #1130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3fc3f0
[Refactor] Share per-mesh vertex-stream binding across render passes
Aug 4, 2026
e219bd3
Add standard license header to RenderVertexStreamBinding.swift
Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 1 addition & 53 deletions Sources/UntoldEngine/Renderer/RenderExtensionModelSurface.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,59 +494,7 @@ private func drawModelSurfaceMeshes(
index: Int(modelPassFragmentUniformIndex.rawValue)
)

let jointTransformBuffer = mesh.skin?.jointTransformsBuffer
var hasArmature = getEntityComponent(entityId: entityId, componentType: SkeletonComponent.self) != nil && jointTransformBuffer != nil
renderEncoder.setVertexBytes(
&hasArmature,
length: MemoryLayout<Bool>.stride,
index: Int(modelPassHasArmature.rawValue)
)

renderEncoder.setVertexBuffer(
mesh.metalKitMesh.vertexBuffers[Int(modelPassVerticesIndex.rawValue)].buffer,
offset: 0,
index: Int(modelPassVerticesIndex.rawValue)
)
renderEncoder.setVertexBuffer(
mesh.metalKitMesh.vertexBuffers[Int(modelPassNormalIndex.rawValue)].buffer,
offset: 0,
index: Int(modelPassNormalIndex.rawValue)
)
renderEncoder.setVertexBuffer(
mesh.metalKitMesh.vertexBuffers[Int(modelPassUVIndex.rawValue)].buffer,
offset: 0,
index: Int(modelPassUVIndex.rawValue)
)
renderEncoder.setVertexBuffer(
mesh.metalKitMesh.vertexBuffers[Int(modelPassTangentIndex.rawValue)].buffer,
offset: 0,
index: Int(modelPassTangentIndex.rawValue)
)
renderEncoder.setVertexBuffer(
mesh.metalKitMesh.vertexBuffers[Int(modelPassJointIdIndex.rawValue)].buffer,
offset: 0,
index: Int(modelPassJointIdIndex.rawValue)
)
renderEncoder.setVertexBuffer(
mesh.metalKitMesh.vertexBuffers[Int(modelPassJointWeightsIndex.rawValue)].buffer,
offset: 0,
index: Int(modelPassJointWeightsIndex.rawValue)
)

if let jointTransformBuffer {
renderEncoder.setVertexBuffer(
jointTransformBuffer,
offset: 0,
index: Int(modelPassJointTransformIndex.rawValue)
)
} else {
var identityMatrix = matrix_identity_float4x4
renderEncoder.setVertexBytes(
&identityMatrix,
length: MemoryLayout<simd_float4x4>.stride,
index: Int(modelPassJointTransformIndex.rawValue)
)
}
renderEncoder.bindModelVertexStreams(mesh: mesh, entityId: entityId)

for submesh in mesh.submeshes {
renderEncoder.drawIndexedPrimitivesTracked(
Expand Down
Loading
Loading