feat: add Command.ArgValidator for tree-wide argument validation#2377
Open
dearchap wants to merge 1 commit into
Open
feat: add Command.ArgValidator for tree-wide argument validation#2377dearchap wants to merge 1 commit into
dearchap wants to merge 1 commit into
Conversation
ArgValidator is an optional hook that runs before Before and Action. It is inherited by subcommands unless they set their own. Returning a non-nil error short-circuits the command. Closes urfave#2327
0454780 to
1efb810
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Adds
ArgValidatorto*cli.Command— an optional hook that runs beforeBeforeandAction. It is inherited by subcommands unless they set their own. Returning a non-nil error short-circuits the command and propagates as the exit error.This is useful for security-boundary CLIs that need to reject shell metacharacters or other patterns before user-supplied bytes reach an exec call, as well as for tracing, metrics, or authz middleware that applies tree-wide.
Which issue(s) this PR fixes:
Closes #2327
Testing
go test ./...passesgo vet ./...passesmake v3diffshows only the newArgValidatorFunctype andArgValidatorfieldmake v3approverun to update API surface docsRelease Notes