docs: Add network handling section and detailed network architecture … #390
+178
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for urunc Signed-off-by: Yash <neiljar888@gmail.com>
✅ Deploy Preview for urunc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cmainas
reviewed
Jan 26, 2026
Contributor
cmainas
left a comment
cmainas
left a comment
There was a problem hiding this comment.
Hello @neiljar ,
as I mentioned in #120 it would be better to discuss about the document before you open the PR. Unfortunately, these changes are not the design document we are looking for. Some of the issues with the current proposal:
- The whole documentation refers to unikernels as guests to include single application kernels too. Similarly, the documentation should refer to VMMs as monitors, since we support for software-based sandboxes too.
- The document is not technically correct (e.g.
connect the VM's virtual network interface to the container's network namespace,Both interfaces are brought up). Unfortunately, there are too many to go over them one by one. - The document does not provide any more information than what users could get from simply reading the code. This is not a design document.
Contributor
|
Hello @sidneychang , I think your comment is about a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new document on network handling in
urunc, detailing the network architecture, including the creation ofTAP devicesand Traffic Control (TC) rules. It also outlines two network modes: dynamic and static, along with their configurations and use cases. Additionally, a section on the network setup process and future improvements is included to enhance understanding ofurunc'snetworking capabilities.#120
please review and provide some suggestions. // @cmainas