feat: update ItalicNode to use repeated children instead of content#4566
Merged
johnnyjoygh merged 2 commits intousememos:mainfrom Mar 28, 2025
Merged
feat: update ItalicNode to use repeated children instead of content#4566johnnyjoygh merged 2 commits intousememos:mainfrom
johnnyjoygh merged 2 commits intousememos:mainfrom
Conversation
Contributor
|
@singhanubhavme you need to upgrade gomark version in this PR to avoid linter errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the markdown rendering logic to align with recent changes in the gomark package, specifically the refactored Italic node structure.
The upstream parser now uses a child-based representation (Children []Node) for ast.Italic instead of a simple Content string. This allows for nested inline elements within italic text (e.g., links inside italic).
Key Changes:
Related PR:
Companion PR in the gomark repo (must be merged first):
👉 Refactor Italic Node Structure for Nested Inline Support