A stable check name for the per-package floor runs - #20
Merged
Conversation
`floor-per-package` names itself after its matrix entry, which is what makes
a failure legible — you see WHICH floor broke without opening anything. Two
costs come with that: the name changes with the repository's declared
ranges, so it can never be a required check, and an empty matrix renders the
uninterpolated `${{ matrix.run.dep }}` in the UI.
This job has one name, always reports, and fails if any entry failed.
The case it exists to catch is the one that reads as a pass: a matrix that
was SKIPPED while the plan found floors to exercise. `skipped` is a gap, not
a success, and a required check that never reports is indistinguishable from
one that passed — which is why the `if` is `always()`.
Six cases checked against the branching before committing: count zero with
a skipped matrix passes; success passes; failure, skipped-with-work,
cancelled, and a failed plan each fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workflow-only — no
@theokit/dep-checkrelease.floor-per-packagenames itself after its matrix entry, which is what makes a failure legible: the run that just found a real defect intheokit-sdkreported itself as "@theokit/sdk@4.53.1, the floor only some packages claim", and that is readable without opening anything.Two costs come with that:
${{ matrix.run.dep }}in the UI, which is whattheokit-uiandtheokitshow right now.floors the shared pin cannot reach — resulthas one name, always reports, and fails if any entry failed. It is the one to mark required in branch protection.The case it exists to catch
A matrix that was skipped while the plan found floors to exercise. That reads as a pass and is a gap.
if: always()is deliberate for the same reason — a required check that never reports is indistinguishable from one that passed, and blocks the pull request forever.Six cases checked against the branching before committing:
Context
This is the first release where the per-package leg ran in anger, and it found a real defect immediately:
@theokit/sdk-memorydeclares>=4.53.1, and every@theokit/sdkbelow4.54.0publishes.d.tsfiles that do not typecheck — 6 to 7 errors across nine sampled versions. Details in theokit-sdk#423.zizmor: no findings.