v1 follows main, not only releases - #21
Merged
Merged
Conversation
`advance-v1` in release.yml moves the ref after a publish, which covers a change that bumps the package. It does not cover a change to the workflows themselves — and those are most of them. The full-depth checkout, the build step, the per-package floor runs and the stable result check each landed on `main` with no version bump, and each had to be pushed to `v1` by hand or it reached no consumer at all. That is #13's shape, in the fix for #13's sibling: shipped, green, and not delivered. I moved the ref by hand three times today without noticing the pattern until a workflow-only merge left it stale again. So `v1` follows `main`, with one condition: the `dep-check-version` pinned in dep-check.yml must already be on the registry. A commit that bumps it lands on `main` BEFORE the tag that publishes it, and moving `v1` there would send every consumer to `npx @theokit/dep-check@<unpublished>` — a failure at the point of use, which is worse than lagging. In that state this job holds and release.yml moves the ref once the publish succeeds. Checked both states: the current pin (0.7.0, published) moves; an unpublished version holds. The read-back follows the annotated-tag indirection, same as release.yml. Refs #15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #15. Workflow-only.
The fix for #15 had #13's shape inside it
advance-v1inrelease.ymlmoves the ref after a publish. That covers a change that bumps the package — and most changes here do not bump the package.The full-depth checkout, the build step, the per-package floor runs, the stable result check: each landed on
mainwith no version bump, and each had to be pushed tov1by hand or it reached no consumer at all. I did that three times today without noticing the pattern, until a workflow-only merge left the ref stale again.Shipped, green, not delivered. Exactly what #13 was about.
So
v1followsmainWith one condition: the pinned
dep-check-versionmust already be on the registry.A commit that bumps it lands on
mainbefore the tag that publishes it. Movingv1there would send every consumer tonpx @theokit/dep-check@<unpublished>— a failure at the point of use, which is worse than lagging behind. In that state this job holds andrelease.ymlmoves the ref once the publish succeeds.Both states checked:
The read-back follows the annotated-tag indirection, same as
release.yml—.object.shais the tag object, not the commit.contents: writeon this job only; the rest of CI keepscontents: read.zizmor: no findings.