dep-check 0.9.1: the org audit read the pre-0.9.0 drift shape - #26
Merged
Conversation
0.9.0 gave `ceilingDrift` a `direction` and taught check C to use it. The organisation-wide audit calls the same function and was left reading the old shape, so a published package whose floor sits above `latest` would have printed `(undefined behind)` and been filed under `contract` — the exact mislabelling 0.9.0 set out to remove, surviving in the one command that sweeps packages no repository here contains. Caught before it ran anywhere: the audit is not part of the per-repository gate, so nothing would have exercised it until someone swept the scope. Refs #24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releases
@theokit/dep-check@0.9.1. Follow-up to #24, fixing something0.9.0introduced.What 0.9.0 broke
It gave
ceilingDriftadirectionfield and taught check C to use it.ceilingDrifthas a second caller —dep-check audit, the organisation-wide sweep — and that one was left reading the old shape.A published package whose floor sits above
latestwould have printed:undefined behind, filed undercontract— the exact mislabelling0.9.0set out to remove, surviving in the one command that sweeps packages no repository in this checkout contains.After
Same three-way severity as check C, same wording.
How it was caught
Not by a test — by asking, before calling the work done, which commands
ceilingDriftreaches and whether they all read the new shape. The audit is not part of the per-repository gate, so nothing would have exercised it until someone ran a scope-wide sweep, and by thenundefined behindwould have read as a finding rather than as a defect in the reporter.Sixth defect of this family the gate has produced today, and the first I introduced while fixing the fifth.