The root of a jar+file or zip uri should only exist if the underlying file exist#2720
Merged
DavyLandman merged 1 commit intomainfrom Mar 18, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2720 +/- ##
=======================================
- Coverage 46% 46% -1%
+ Complexity 6680 6668 -12
=======================================
Files 795 795
Lines 65905 65913 +8
Branches 9881 9883 +2
=======================================
- Hits 30717 30704 -13
- Misses 32808 32830 +22
+ Partials 2380 2379 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
toinehartman
approved these changes
Mar 17, 2026
jar+file or zip uri should only exist if the underlying file exist
…ng, even if the underlying file did not exist
b48f605 to
47b6e3a
Compare
|
jurgenvinju
requested changes
Mar 17, 2026
Member
jurgenvinju
left a comment
There was a problem hiding this comment.
ok good catch! I have some comments in slack
Member
Author
|
Ok, I discussed it with @jurgenvinju the current PR was fine as is, there was a misunderstanding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



before:
after: