Skip to content

The root of a jar+file or zip uri should only exist if the underlying file exist#2720

Merged
DavyLandman merged 1 commit intomainfrom
fix/empty-jar-uri-exists-always-true
Mar 18, 2026
Merged

The root of a jar+file or zip uri should only exist if the underlying file exist#2720
DavyLandman merged 1 commit intomainfrom
fix/empty-jar-uri-exists-always-true

Conversation

@DavyLandman
Copy link
Member

@DavyLandman DavyLandman commented Mar 17, 2026

before:

rascal>exists(|mvn://x--b--2|)
bool: true

after:

rascal>exists(|mvn://x--b--2|)
bool: false

@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 46%. Comparing base (246874f) to head (47b6e3a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/org/rascalmpl/uri/zip/ZipFileResolver.java 0% 7 Missing ⚠️
src/org/rascalmpl/uri/jar/JarFileResolver.java 71% 1 Missing and 1 partial ⚠️
.../org/rascalmpl/uri/jar/JarInputStreamResolver.java 0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              main   #2720   +/-   ##
=======================================
- Coverage       46%     46%   -1%     
+ Complexity    6680    6668   -12     
=======================================
  Files          795     795           
  Lines        65905   65913    +8     
  Branches      9881    9883    +2     
=======================================
- Hits         30717   30704   -13     
- Misses       32808   32830   +22     
+ Partials      2380    2379    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DavyLandman DavyLandman changed the title Fixed a bug where the root of a jar+file or zip uri was always existi… The root of a jar+file or zip uri should only exist if the underlying file exist Mar 17, 2026
…ng, even if the underlying file did not exist
@DavyLandman DavyLandman force-pushed the fix/empty-jar-uri-exists-always-true branch from b48f605 to 47b6e3a Compare March 17, 2026 17:14
@sonarqubecloud
Copy link

Copy link
Member

@jurgenvinju jurgenvinju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok good catch! I have some comments in slack

@DavyLandman
Copy link
Member Author

Ok, I discussed it with @jurgenvinju the current PR was fine as is, there was a misunderstanding.

@DavyLandman DavyLandman merged commit 8fa19c3 into main Mar 18, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants