fix(odd-status): export the Claude credential from the shell instead of putting it on env's argument vector - #51
Merged
Conversation
…of putting it on env's argument vector Closes #46 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
scripts/run-claude.shreads the setup's credential file into a variable, exports it in a subshell andexecs the CLI there, instead ofenv "VAR=$(cat file)" claude ..., which placed the credential onenv's argument vector (world-readable on Linux, recorded by execve auditing). A read that fails now fails the step. A new shared launch case puts a fakeenvfirst onPATHand asserts it is never called, that the credential still reaches the CLI's variable, and that no argument of the CLI carries it;tests/odd-status/test_launch.pyreplays it.Why
Closes #46.
How to test
shellcheck, ruff and pytest (180 passed) locally; the
odd-status/claudecell runs the launch for real.Review
Review subagent: green (three minors, all applied: comment wording, the read-before-export, the test comment). Security review: no findings.
🤖 Generated with Claude Code