fix(actions): retry the run-time downloads on a connection reset, not only on a timeout or a 5xx - #56
Merged
Merged
Conversation
… only on a timeout or a 5xx Closes #55 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55
What
--retry-all-errorsnext to--retry 3on every run-time download: the fourcurllines of the three setups' install scripts and the two of thelintjob inci.yml(actionlint's archive and checksums). Each setup's install test asserts everycurlcall carries both flags.Why
Run https://github.com/using-system/oddyssey-actions/actions/runs/35471779837 failed on
setup-claude'sInstall Claude Codein 159 ms withcurl: (35) Recv failure: Connection reset by peerfetchingmanifest.json.--retryalone retries only what curl calls transient - a timeout, or a 408, 429, 500, 502, 503 or 504 - so a reset, a refused connection or a truncated body fails the step on the first blip.--retry-all-errors(curl >= 7.71.0; every GitHub runner's curl is 8.x) makes the three retries cover every failure.What lands is still verified as before: the manifest checksum (
setup-claude), the release'sSHA256SUMS.txt(setup-copilot), the pinnedSHA256_*(setup-opencode),sha256sum --check(ci.yml); with-o, curl discards a partial body before retrying. The cost: a genuine failure (a wrong pin, a 404) is retried three times before it fails, about seven seconds of backoff.No README changes: nothing about what is downloaded, from where, with which credential (none) or how it is verified changes.
Review
Review subagent and security review both green; the one minor (the comment's HTTP-code list) fixed and re-reviewed green. actionlint, shellcheck, ruff, pytest (221 passed) green locally after the last fix.
🤖 Generated with Claude Code