chore(mcp): bump the local stack image to grafana/otel-lgtm 0.33.1 - Pyroscope 2.3.1, the image's healthcheck waits for the stack's ready marker - #641
Merged
Conversation
…Pyroscope 2.3.1, the image's healthcheck waits for the stack's ready marker IMAGE moves to grafana/otel-lgtm:0.33.1 with the unit-test expectations naming the tag; the env reference's pinned-tag line moves and LGTM_READY_FILE joins its lifecycle section (the marker the image's own HEALTHCHECK now waits for - nothing of the server reads it, odd_stack_up keeps its own probes). Grafana 13.2.1, the collector 0.160.0, Prometheus 3.14.0, Tempo 3.0.3 and Loki 3.7.7 unchanged. Verified live: the four signals round-tripped on the 0.33.1 container, unit and integration suites green. Closes #640 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
IMAGEmoves tografana/otel-lgtm:0.33.1(Pyroscope 2.3.1; Grafana 13.2.1, OpenTelemetry Collector 0.160.0, Prometheus 3.14.0, Tempo 3.0.3 and Loki 3.7.7 unchanged), with the six unit-test expectations naming the tag, the env reference's pinned-tag line, and one bullet added to the reference's lifecycle section:LGTM_READY_FILE, the markerrun-all.shwrites once every component is up (default/tmp/ready) and that the image's ownHEALTHCHECKnow waits for before probing the components (grafana/docker-otel-lgtm#1814). The image's comparev0.33.0...v0.33.1touches, outside examples, CI, tests and tooling files,docker/Dockerfile(the Pyroscope version and the base digest),docker/run-all.shanddocker/healthcheck.shonly, so the env-surface catalog keeps its shape but for that variable.The healthcheck change touches nothing the server does:
odd_stack_upandodd_stack_statusjudge readiness with their own probes (the four backends through Grafana's datasource proxy, the bounded plugin-wiring wait, the OTLP listener), anddocker run/docker inspectneither set nor read the container's health - the reference bullet says so. The skill's verified-versions line needs no change (Grafana stays 13.2.1).Closes #640
Verified live, on this machine
bash integration-tests/mcp-server/run.sh) against real Docker on the new image: all seven scripts passed (config surface, stack config, daemon unreachable, env, idempotent up, lifecycle, reset).llmbench-api,llmbench-mcp,llmbench-agent) driven with the storedllmbench-store-loadbenchmark (2 min, 4,000+ requests), then probed through gcx with the skill'sprobe_services.py- traces, metrics, logs and profiles present for all three - and one real query per backend (a profile top, a trace ops table, a log count, a counter delta). In the container:/api/health13.2.1,pyroscope --version2.3.1,otelcol-contrib --version0.160.0, Prometheus 3.14.0, Tempo 3.0.3, Loki 3.7.7;/tmp/readypresent, the image's healthhealthy.check_stack_reference.py): 6 references follow the contract. The package validated as CI does:apm install --target claude && apm audit- 127 files scanned, no issue; the tree put back.Review outcome
One round, no finding. A separate reviewer sub-agent verified with real commands that the image compare changes nothing the catalog describes beyond
LGTM_READY_FILEand that the bullet states whatrun-all.shandhealthcheck.shdo, thatstack.pyreads neither the Docker health nor the marker and sets no--health-*flag, that no file still names 0.33.0 outside history and generated trees, that the six test hunks replace the tag string only, and that lint and the 260 unit tests pass.Harness path
Not on the path of
/odd-observe,/odd-verifyor/odd-statusin what a run reads or runs beyond one tag string and one bullet of a reference read at env-configuration time; no measurement owed.🤖 Generated with Claude Code