feat: add personal assistant home - #36
Open
sddxl150-star wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
合并评估(monkeycode-ai 已本地验证:前端 Vite 构建通过)
功能方向认可:AssistantHome 增量仅 2 个文件约 228 行,响应式与可访问性处理到位。但它作为 #35 的 stacked PR,同样受 #35 两个阻断问题影响:
1. 核心流程在默认配置下不可用(严重)
- 依赖 #35 的
POST /admin/collaboration/planning-room,该接口默认部署下返回 400(缺 orchestrator 配置)。 - 更关键:
startAssistantChat在创建失败时静默 return,用户点击发送后无任何反馈。要求补充错误提示,不能静默失败。
2. i18n 缺失(次要)
tr('个人助手')、tr('助手')未加入 i18n.js 翻译表,非中文语言下会显示中文。建议补充各语言条目。
依赖 #35 修复后再合并本 PR。
(说明:上方 PR #35 下有一条 "permission probe" 评论为权限测试,可忽略。)
Contributor
|
本 PR 的修复版已随 #37 合并到 master(含前端错误提示与 i18n 修复)。建议关闭本 PR。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on
This is a stacked PR. After #35 merges, the remaining diff is limited to frontend/src/App.vue and frontend/src/AssistantHome.vue.
Summary
Validation