Skip to content

feat(http): add default headers for HTTP requests in HttpParamsEditor… - #2562

Closed
AndresTK89 wants to merge 1 commit into
release/v12.0.0from
backlog/http-deleting-header
Closed

feat(http): add default headers for HTTP requests in HttpParamsEditor…#2562
AndresTK89 wants to merge 1 commit into
release/v12.0.0from
backlog/http-deleting-header

Conversation

@AndresTK89

Copy link
Copy Markdown

… and executor catalog

PLEASE READ BEFORE CONTINUING

To help us understand your contribution, please include the following in your pull request:

  • A detailed explanation of the changes you've made.
  • The reasoning behind these changes.
  • A reference to the issue that this pull request addresses.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

🛑 AI review — High/critical findings

One or more high/critical issues were found. Please review and fix before merging if they're real.

architecture (gemini-3-flash-lite) — clean

Summary: Frontend updates to SOAR HTTP parameter editor default headers and catalog definitions.

No findings.

🛑 bugs (gemini-3-flash-lite) — high/critical — please review

Summary: Setting CORS Access-Control-Allow-Origin as a default outgoing request header is incorrect and can break requests.

  • high frontend/src/features/soar/components/HttpParamsEditor.tsx:13 — Access-Control-Allow-Origin is a CORS response header sent by servers, not a request header sent by clients. Including it in DEFAULT_HEADER_ROWS will send invalid/confusing headers on outgoing HTTP requests.
  • high frontend/src/features/soar/types/soar.types.ts:161 — Access-Control-Allow-Origin is incorrectly specified as a default request header in the EXECUTOR_CATALOG.

⚠️ security (gemini-3-flash-lite) — minor findings

Summary: Added overly permissive Access-Control-Allow-Origin: * default header in HTTP/SOAR editor

  • low frontend/src/features/soar/components/HttpParamsEditor.tsx:15 — Defaulting outgoing HTTP request headers to include 'Access-Control-Allow-Origin: *' is inappropriate for client/sender requests (CORS headers govern browser responses to servers, not outgoing client requests) and may cause confusion or security misconceptions in integrations. Remove or clarify this header.

🔴 go-deps — pending updates

🔍 Discovered 30 Go projects

📦 Dependencies with updates available:

  📁 ./plugins/soc-ai:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31
     - golang.org/x/crypto: v0.56.0 → v0.57.0

  📁 ./plugins/shared:
     - golang.org/x/crypto: v0.56.0 → v0.57.0

  📁 ./plugins/feeds:
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.31
     - golang.org/x/crypto: v0.56.0 → v0.57.0
     - golang.org/x/sync: v0.22.0 → v0.23.0

  📁 ./plugins/sophos:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31

  📁 ./plugins/bitdefender:
     - golang.org/x/crypto: v0.56.0 → v0.57.0

  📁 ./plugins/soar:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31

  📁 ./plugins/stats:
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.31

  📁 ./plugins/azure:
     - golang.org/x/crypto: v0.56.0 → v0.57.0

  📁 ./plugins/alerts:
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.31

  📁 ./plugins/geolocation:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31

  📁 ./plugins/o365:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31

  📁 ./plugins/gcp:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31
     - golang.org/x/crypto: v0.56.0 → v0.57.0

  📁 ./plugins/rule-flood-guard:
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.31

  📁 ./backend:
     - github.com/golang-migrate/migrate/v4: v4.19.1 → v4.20.1
     - github.com/jackc/pgx/v5: v5.10.0 → v5.11.0
     - golang.org/x/crypto: v0.56.0 → v0.57.0
     - golang.org/x/oauth2: v0.36.0 → v0.37.0
     - golang.org/x/sync: v0.22.0 → v0.23.0
     - golang.org/x/sys: v0.47.0 → v0.48.0

  📁 ./agent-manager:
     - golang.org/x/sync: v0.22.0 → v0.23.0

  📁 ./agent:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31
     - golang.org/x/sys: v0.47.0 → v0.48.0

❌ Please update dependencies before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants