Open
Conversation
fogelito
reviewed
Feb 5, 2025
| // Test mixing count with other queries | ||
| $documents = $database->find('testCountQueries', [ | ||
| Query::count('integer'), | ||
| Query::limit(1), |
Contributor
There was a problem hiding this comment.
Perhaps should validate not using limits / offset queries Since they happen after the aggregations.
Most likely count/sum will return 1 row.
Contributor
Author
There was a problem hiding this comment.
We run aggregate SQL after the main SQL using a subquery so this shouldn't be a problem
fogelito
reviewed
Feb 5, 2025
| $this->assertEquals(1, $documents[0]->getAttribute('integer')); | ||
|
|
||
| $documents = $database->find('testCountQueries', [ | ||
| Query::count('integer'), |
Contributor
There was a problem hiding this comment.
- Do we allow select queries when using aggregation queries, which will lead to errors?
- Do we allow Query::count('integer'), Query::sum('integer') will both have the alias?
Contributor
There was a problem hiding this comment.
- Do we validate aggregation queries in nested queries?
Contributor
Author
There was a problem hiding this comment.
- No we do not allow select queries when using aggregation queries, we have a validator for that.
- We don't allow mixing aggregate queries
- I haven't touched nested queries, so I don't think so
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements count queries and generally cleans up the code of how aggregates work so it's more maintainable. This supports all DB adapters excluding MongoDB.