Repository navigation
ci: stop the review CLI from updating itself mid-run - #372
Merged
Merged
Conversation
The ocr launcher spawns a detached `npm i -g @alibaba-group/open-code-review@latest` whenever a newer release exists. Since 1.12.10 and 1.12.11 shipped, that reinstall races the action's own ocr calls, so the review step fails with "binary not found" or "Cannot find module /usr/local/bin/ocr". OCR_NO_UPDATE turns the check off and keeps the CLI on the pinned 1.12.9. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ChiragAgg5k
requested review from
Meldiron,
abnegate,
eldadfux and
loks0n
as code owners
October 3, 2026 07:24
🟢 Tier S · Ready to merge
The review action now receives
📂 Walkthrough · 1
Reviewed |
![hansi-codes[bot]](https://avatars.githubusercontent.com/in/5046327?s=60&v=4){kind=small}
30 of 34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
reviewjob started failing on every pull request after OpenCodeReview 1.12.10 and 1.12.11 were published (2026-09-28/29); the last green run was 2026-09-29 09:14, before 1.12.11.The pinned 1.12.9 launcher (
bin/ocr.js) spawns a detachednpm i -g @alibaba-group/open-code-review@latestwhenever a newer release exists. That reinstall races the action's ownocrcalls, so the step fails partway through. On #371 the first attempt died withOpenCodeReview binary not foundand the rerun withCannot find module '/usr/local/bin/ocr', both right after the CLI had run successfully a few calls earlier. The launcher skips the check whenOCR_NO_UPDATEis set, which also keeps the CLI on the pinnedocr_versionas the workflow already intends.This workflow runs on
pull_request_target, so it always usesmain's copy: this PR's ownreviewcheck runs the broken workflow and will fail. The fix takes effect for pull requests after it merges.Part of appwrite/appwrite#13828 (blocks #371).
Related: appwrite/appwrite#13828