feat: v2 containers #63
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| /vendor/ | ||
| /.idea/ | ||
| .phpunit.result.cache | ||
| *.phpdisabled | ||
| .DS_Store |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| <?php | ||
|
|
||
| namespace Utopia\Containers; | ||
|
|
||
| use Utopia\Containers\Usage; | ||
|
|
||
| abstract class Adapter | ||
|
Comment on lines
+3
to
+7
There was a problem hiding this comment. 🧩 Analysis chainAdapter contract mostly looks good, but clean up imports and ensure A few points on this new abstraction:
After fixing the import, aligning Also applies to: 19-31 🏁 Script executed: #!/bin/bash
# View Adapter.php file to see full contract
cat src/Containers/Adapter.phpLength of output: 1785 🏁 Script executed: #!/bin/bash
# Find and view DockerCLI implementation
find . -name "DockerCLI.php" -o -name "DockerAPI.php" | head -5Length of output: 77 🏁 Script executed: #!/bin/bash
# Find Networks class
find . -name "Networks.php" | head -5Length of output: 29 🏁 Script executed: #!/bin/bash
# Search for other adapter implementations
find . -path "*/Containers/*" -name "*.php" -type f | grep -i adapterLength of output: 196 🏁 Script executed: #!/bin/bash
# Check PHP version and Pint configuration for linting
ls -la | grep -E 'pint|phpstan|composer'Length of output: 187 🏁 Script executed: #!/bin/bash
# View DockerCLI implementation
cat src/Containers/Adapter/DockerCLI.phpLength of output: 14679 🏁 Script executed: #!/bin/bash
# View DockerAPI implementation
cat src/Containers/Adapter/DockerAPI.phpLength of output: 21754 🏁 Script executed: #!/bin/bash
# View Networks class
cat src/Containers/Networks.phpLength of output: 1350 🏁 Script executed: #!/bin/bash
# Check DockerAPI class declaration and inheritance
head -20 src/Containers/Adapter/DockerAPI.phpLength of output: 508 🏁 Script executed: #!/bin/bash
# Check pint configuration
cat pint.jsonLength of output: 391 Fix Adapter contract: clean import, add return types, align getUsage implementation across adapters Three confirmed issues:
|
||
| { | ||
| abstract public function createNetwork(string $name, bool $internal): void; | ||
|
|
||
| abstract public function removeNetwork(string $name): void; | ||
|
|
||
| abstract public function networkExists(string $name): bool; | ||
|
|
||
| abstract public function connect(string $container, string $network): void; | ||
|
|
||
| abstract public function disconnect(string $container, string $network, bool $force); | ||
|
|
||
| /** | ||
| * @return list<Network> | ||
| */ | ||
| abstract public function listNetworks(): array; | ||
|
|
||
| abstract public function getUsage(string $container): ?Usage; | ||
|
|
||
| /** | ||
| * @param array<string, string> $filters | ||
| * @return array<string, Usage> Map of container ids to usage stats | ||
| */ | ||
| abstract public function listUsage(array $filters): array; | ||
|
|
||
| abstract public function pull(string $image): void; | ||
|
|
||
| /** | ||
| * @param array<string, string> $filters | ||
| * @return Container[] | ||
| */ | ||
| abstract public function list(array $filters): array; | ||
|
|
||
| abstract public function run( | ||
| string $name, | ||
| string $image, | ||
| string $hostname, | ||
| array $command, | ||
| array $entrypoint, | ||
| ?string $workdir, | ||
| array $environment, | ||
| array $mounts, | ||
| array $labels, | ||
| ?string $network, | ||
| ?float $cpus, | ||
| ?int $memory, | ||
| ?int $swap, | ||
| RestartPolicy $restart, | ||
| bool $remove, | ||
| ): string; | ||
|
|
||
| /** | ||
| * @param string[] $command | ||
| * @param array<string, string> $vars | ||
| */ | ||
| abstract public function execute(string $name, array $command, string &$output, array $vars, int $timeout): bool; | ||
|
|
||
| /** | ||
| * Remove Container | ||
| */ | ||
| abstract public function remove(string $name, bool $force): bool; | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor language fixes in introduction
Two small text issues flagged by tooling:
Not critical, but easy polish for the new package branding.
🧰 Tools
🪛 LanguageTool
[grammar] ~9-~9: Use a hyphen to join words.
Context: ...-php/framework) project it is dependency free and can be used as standalone with ...
(QB_NEW_EN_HYPHEN)
🤖 Prompt for AI Agents