SIGPIPE panics

Using tag/latest-commit

diffutils diff /etc/pacman.conf /dev/null | :

thread 'main' (39158) panicked at src/diff.rs:94:41:
called `Result::unwrap()` on an `Err` value: Os { code: 32, kind: BrokenPipe, message: "Broken pipe" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Yes, I have noticed this .unwrap() on io before.

What is the desired behavior? Let this pass, because it is intentionally?

        if let Err(e) = io::stdout().write_all(&result) {
            // let broken pipe pass, report other errors
            if e.kind() != io::ErrorKind::BrokenPipe {
                eprintln!("{e}");
                return ExitCode::FAILURE;
            }
        }

I am also working on an optimized error handling with enums to make it library friendly.

https://github.com/uutils/coreutils/blob/995c9e04a6cc34a3a95b23a26fa59ae87e7744bd/src/uucore/src/lib/mods/panic.rs#L28-L45

fix: SIGPIPE panics - issue uutils#192

I researched your hint and found uutils/coreutils#9657, so I just copied that behavior and added PR #194. Could you please check that.

It should be able to import uucore instead of copy and pasting.

Fix broken pipe error, issue uutils#192

Yes, that is what I did. I still needed to implement the imported functionality.

With my current implementation you will get

>diffutils diff /etc/pacman.conf /dev/null | :
diffutils: write error: Broken pipe

GNU diff does suppress it completely.

This could easily be changed, I would just need to add one line in diff.rs:

pub fn main(opts: Peekable<ArgsOs>) -> ExitCode {
    uucore::panic::mute_sigpipe_panic();

Would you prefer that? It would mimic GNU diff behavior, but has less information.

I'm OK. But maintainer should determine how to fix this instead of me.

Fine, I strongly believe, it should stay as I fixed it.

As the issues were closely related I fixed #165 also in this PR.

Navigation Menu

Repository navigation

SIGPIPE panics #192

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

SIGPIPE panics #192

Description

Activity

GunterSchmidt commented on Mar 8, 2026

oech3 commented on Mar 9, 2026

GunterSchmidt commented on Mar 9, 2026

oech3 commented on Mar 9, 2026

GunterSchmidt commented on Mar 9, 2026

GunterSchmidt commented on Mar 10, 2026

oech3 commented on Mar 10, 2026

GunterSchmidt commented on Mar 10, 2026

GunterSchmidt commented on Mar 12, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions