Skip to content

sed: fix brace quantifier delimiter and {,n} bound edge cases#463

Merged
sylvestre merged 1 commit into
uutils:mainfrom
sylvestre:fix-brace-quantifier-edge-cases
Jun 14, 2026
Merged

sed: fix brace quantifier delimiter and {,n} bound edge cases#463
sylvestre merged 1 commit into
uutils:mainfrom
sylvestre:fix-brace-quantifier-edge-cases

Conversation

@sylvestre

Copy link
Copy Markdown
Contributor

@LoukasPap what do you think ? :)

@codecov

codecov Bot commented Jun 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.12%. Comparing base (d9cd538) to head (90ba2cd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #463   +/-   ##
=======================================
  Coverage   83.12%   83.12%           
=======================================
  Files          13       13           
  Lines        5895     5885   -10     
  Branches      340      339    -1     
=======================================
- Hits         4900     4892    -8     
+ Misses        992      990    -2     
  Partials        3        3           
Flag Coverage Δ
macos_latest 83.79% <100.00%> (+<0.01%) ⬆️
ubuntu_latest 83.87% <100.00%> (+<0.01%) ⬆️
windows_latest 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq

codspeed-hq Bot commented Jun 14, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 3.4%

❌ 1 regressed benchmark
✅ 10 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
number_fix 574.9 ms 595.2 ms -3.4%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing sylvestre:fix-brace-quantifier-edge-cases (90ba2cd) with main (d9cd538)

Open in CodSpeed

@LoukasPap

Copy link
Copy Markdown
Contributor

That's very good! Hadn't thought about simplifying the logic of {,} and {,n}, neither the delimiter case (adding the forgotten test cases was a nice catch too). I think the code is now both smarter and cleaner.

@sylvestre sylvestre merged commit b90c599 into uutils:main Jun 14, 2026
30 of 31 checks passed
@sylvestre

Copy link
Copy Markdown
Contributor Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants