[v8] Propagate v8_cppgc_microtask_queue flag to common.gypi#259
Merged
victorgomes merged 1 commit intoJun 30, 2026
Merged
Conversation
v8_cppgc_microtask_queue affects the public ABI of v8::MicrotaskQueue. When enabled, it alters the class hierarchy (inheriting from cppgc::GarbageCollected) and changes the return type of MicrotaskQueue::New(). This flag must be propagated to GYP to ensure that native addons built via node-gyp are compiled with the identical V8 memory layout and method signatures as the Node.js executable, preventing silent ABI breakages and segfaults. TAG=agy CONV=21b9994c-2327-48b5-b81f-aa460e16a410
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v8_cppgc_microtask_queue affects the public ABI of v8::MicrotaskQueue. When enabled, it alters the class hierarchy (inheriting from cppgc::GarbageCollected) and changes the return type of MicrotaskQueue::New().
This flag must be propagated to GYP to ensure that native addons built via node-gyp are compiled with the identical V8 memory layout and method signatures as the Node.js executable, preventing silent ABI breakages and segfaults.