chore: filter out attributes for non-public members in CEM config#11174
Open
web-padawan wants to merge 1 commit intomainfrom
Open
chore: filter out attributes for non-public members in CEM config#11174web-padawan wants to merge 1 commit intomainfrom
web-padawan wants to merge 1 commit intomainfrom
Conversation
Attributes whose corresponding field member is protected or private (e.g. `type` from InputMixin) were not being excluded from the manifest. This adds a filter that removes attributes when their `fieldName` does not match any remaining public member. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
web-padawan
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typefromInputMixin) were not being excluded from the custom elements manifestfieldNamedoes not match any remaining public memberTest plan
yarn release:cemand verify thatpackages/checkbox/custom-elements.jsonno longer contains thetypeattributetext-field) are not affected by the change🤖 Generated with Claude Code