Refactors and cleans up OTEL's log handler usage#199
Open
nanodirijabl wants to merge 4 commits intootel_logsfrom
Open
Refactors and cleans up OTEL's log handler usage#199nanodirijabl wants to merge 4 commits intootel_logsfrom
nanodirijabl wants to merge 4 commits intootel_logsfrom
Conversation
WWWcool
reviewed
Mar 25, 2026
|
|
||
| -spec init_per_suite(config()) -> config(). | ||
| init_per_suite(C) -> | ||
| % ok = logger:set_primary_config(level, debug), |
Contributor
Author
There was a problem hiding this comment.
Добавил коммент об это строке. Для иллюстративности чтобы была куча логов в коллекторе можно это оставить раскомментированным.
WWWcool
reviewed
Mar 25, 2026
Comment on lines
+123
to
+125
| dbg: | ||
| $(REBAR) ct -v --suite=apps/hellgate/test/hg_invoice_tests_SUITE.erl --group=all_non_destructive_tests --case=payment_big_cascade_success | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Пока оставил для удобства запуска самого "многословного" тесткейса.
WWWcool
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.