Skip to content

refactor: keep native PDFium navigation - #269

Merged
van-geaux merged 4 commits into
mainfrom
feat/issue-193-join-pdf-facing-pages
Oct 8, 2026
Merged

van-geaux merged 4 commits into
mainfrom
feat/issue-193-join-pdf-facing-pages

Conversation

@van-geaux

Copy link
Copy Markdown
Owner

Summary

  • Keep the native Readium/PDFium navigator as the only PDF rendering and gesture surface.
  • Remove the custom spread renderer and custom swipe-axis behavior that made paginated PDFs feel awkward.
  • Retain BookOrbit-owned progress, tap zones, volume navigation, reading direction, links, and color inversion.
  • Rename the PDF option to Remove gap between pages; it only sets native PDFium page spacing to zero for paginated PDFs.
  • Update the PDF testing procedure to describe the native behavior.

Verification

  • ./gradlew --no-daemon --console=plain :app:testDebugUnitTest
  • ./gradlew --no-daemon --console=plain :app:compileDebugAndroidTestKotlin
  • ./gradlew --no-daemon --console=plain :app:lintDebug
  • ./gradlew --no-daemon --console=plain :app:assembleDebug
  • git -c core.whitespace=cr-at-eol diff --check
  • User-confirmed the standard Readium/PDFium behavior works on device.

Artifact

  • Debug APK: Lagrange-debug-202610081432.apk
  • SHA-256: 23a93791904584844b5144ccd51dfc485485331ca1e81ef9bd9a67a1db5839cb

Scope

  • No custom two-page spread pairing.
  • No custom vertical landscape pagination.
  • No custom swipe-axis filtering.

Closes #193

@van-geaux
van-geaux merged commit b786963 into main Oct 8, 2026
1 check passed
@van-geaux
van-geaux deleted the feat/issue-193-join-pdf-facing-pages branch October 8, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Close gaps between two-page PDF spreads

1 participant