[chortya]

Contribution pause

The maintainer lifted the pause and invited split PRs in #286.

• The change is scoped to one feature (EPUB text alignment and hyphenation settings). Independent of the spread and OLED PRs.
• Compatible with the provider-module refactor: reader preferences and UI only.
• Tests and manual-validation status are documented.
• No credentials, cookies, API keys, private server URLs, or generated local data are included.

Summary

EPUB text was never hyphenated, and there was no setting for it or for justification. Two per-library settings are added. They appear in the in-book reader options (Typography) and in the library reader settings (shared EpubTypesettingSettings):

Setting	Values	Readium mapping
Text alignment	Left (default), Justified	textAlign = START (follows text direction, so RTL books keep their own edge) / JUSTIFY
Hyphenation	Auto (default), On, Off	hyphens; Auto hyphenates justified text only

The defaults (Left + Auto) keep today's rendering.

Browser hyphenation needs a content language. Books that declare none get the device language through Readium's language preference (epubFallbackContentLanguage). This is skipped for RTL and CJK device languages, because Readium also derives RTL and vertical layout from the language and those scripts have no hyphenation patterns. All changes apply live without reopening the book. Older stored profiles default to Left + Auto.

Verification

• ./gradlew :app:testDebugUnitTest — 953/953 pass (new EpubTypesettingPreferencesTest: storage round trip, legacy defaults, Auto rules, language fallback). :app:lintDebug — 0 errors. :app:assembleDebug succeeds. No added trailing whitespace; line endings preserved.
• Connected, Pixel Fold API 36 emulator:
  • New EpubTypesettingActivityInstrumentedTest 2/2 — measured inside the reader WebView: default is ragged and unhyphenated; Justified hyphenates long words with flush lines; Off removes hyphens; Left + On hyphenates; a book without a declared language is hyphenated in the device language.
  • ReadiumEpubOpenInstrumentedTest 16/18; the 2 failures (selectsARealReadiumPositionForNonzeroServerPercentage, generatedEpubImageColorOverrideIsUniversalAndIdempotent) also fail on main on this emulator (new typesettingPreferencesMapToReadiumAlignmentHyphensAndLanguage passes).
  • EpubReaderOptionsOverlayInstrumentedTest 4/9 (new epubAlignmentAndHyphenationChoicesUpdateOnlyTheirSettings passes); the same 5 fail on main on this emulator.
• Device: requested after a Galaxy Z Fold8 screenshot showed unhyphenated justified-looking text; used on that device from the fork build. This branch itself was run only on the emulator. The library-settings chips have no dedicated connected test.
• Peer review (Codex GPT-6-Astra): the no-language test assumed an English device locale. Fixed: the page language is checked on any hyphenating locale, and the hyphenation check only runs when that language is English (the fixture text is English).

🤖 Generated with Claude Code

[van-geaux]

Thanks @chortya, the EPUB typesetting changes look good and CI is passing. GitHub still reports a conflict with main, so please update the branch and resolve it before merging.

[chortya]

Thanks! Rebased onto current main and resolved the conflicts with #300: the readium preferences take both the spread and the typesetting parameters, and in the library reader settings "EPUB text" sits above "Unfolded screens". CI is green again. #303 is rebased on top of this branch.

Heads-up: #301 and #302 both add a section at the same spot in docs/testing.md and docs/architecture.md, so whichever merges second will need a quick docs-only rebase. I'll handle that.

[van-geaux]

Thanks @chortya, the implementation and tests look good. As you mentioned, please update the branch after PR #301 is merged and resolve the documentation conflicts. Once that’s done, this should be ready to merge.

[chortya]

Updated on top of #301: resolved the docs conflicts, keeping both the OLED and the alignment/hyphenation sections. CI is green.

[van-geaux]

Reviewed the latest head. No blocking correctness, security, lifecycle, or persistence issues found. Local verification passed 1,002 JVM tests, Android-test Kotlin compilation, lint, and debug APK assembly; GitHub build-and-test is also passing. The CRLF diff-check warning is limited to the repository's existing docs/testing.md line-ending convention.