Repository navigation
fix: offline server restore requires the saved profile's provider (follow-up to #299) - #306
Merged
van-geaux merged 1 commit intoOct 21, 2026
Conversation
Choosing a saved server's address with a different provider while it is unreachable restored that profile offline: the other provider took over its session and cached state, and the profile's provider was overwritten. The offline restore now matches provider as well as URL; a different provider at that address gets the normal setup error instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks done
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution pause
The maintainer lifted the pause and invited split PRs in #286.
AppCoordinator.changeServer).Summary
Follow-up to #299, as discussed in its review: the offline restore matched a saved profile by URL only.
Profiles are keyed by URL, so two profiles can't share an address. The reachable case is a single saved profile (say BookOrbit) whose address is chosen with another provider (say Komga) while the server is unreachable. The switch then:
The restore now requires the provider to match as well. Another provider at that address gets the normal setup error, and the saved profile is left unchanged.
Verification
./gradlew :app:testDebugUnitTest949/949 pass,:app:lintDebug0 errors,:app:assembleDebugsucceeds; line endings preserved.OfflineServerSwitchInstrumentedTest3/3 on a Pixel Fold API 36 emulator. New:anotherProviderAtTheSavedAddressIsNotRestoredOffline, which fails without the fix.🤖 Generated with Claude Code