feat: support OAuth device login for Vana Account - #3
Merged
Conversation
tnunamak
changed the title
Contributor
|
🎉 This PR is included in version 0.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
tnunamak
added a commit
that referenced
this pull request
Jul 2, 2026
Account OAuth login (the OIDC device-grant path added in #3) never returns Personal Server fields on the real token response, so the CLI silently kept a previous account's pinned personalServerUrl in ~/.vana/vana-connect-state.json after switching accounts. Clear it whenever a fresh login reports no PS, and read PS fields from id_token claims as a secondary source alongside the top-level token fields. Surface a clear "no Personal Server found" hint instead of silently omitting it. This is a preparatory correctness/UX fix, not full Account OAuth -> PS sync enablement: Unity Account has no authenticated-session endpoint that mints or returns a caller's Personal Server URL/session token (the legacy connect app's device-poll route does this via personal_servers/sessions tables, but Unity Account doesn't expose an equivalent yet). See the accompanying report for what's still needed server-side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vana-cli/vana-cli-dev, withVANA_OAUTH_CLIENT_ID,VANA_ACCOUNT_CLIENT_ID, andvana login --client-idoverrides/api/auth/devicefallback when Account discovery is unavailableTests
pnpm test test/cli/auth.test.ts test/cli/index.test.tspnpm build