refactor(composer): remove transcribe and speak icons - #555
Merged
Merged
Conversation
The composer toolbar exposed mic (transcribe) and speak (readaloud) buttons. These were the only UI entry points for the host speech capability added in 9948d07. Drop the renderer wiring — the Composer toolbar buttons, their props, and the useComposerSpeech hook — while keeping the underlying host transcribe/synthesize services and the plugin-facing speech API intact, since that capability is provided for plugins rather than inline composer UI. The generic audio file-attachment handling in the composer editor is unaffected and remains.
The composer no longer exposes transcribe/speak buttons (see parent commit), so the contract test asserting those UI hooks (readComposerSource checks on status?.transcribe.available etc.) is obsolete. Remove it and its now-unused import; the host speech-service and IPC-contract tests remain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the composer mic (transcribe) and speak (readaloud) toolbar buttons and the
useComposerSpeechhook, keeping the host speech capability and plugin-facing speech API intact for plugins.Fixes the request to drop the inline icons while preserving the underlying capability.