docs: align theme contract with light selector rules and ui.theme reality - #558
Open
Frank-zhu0404 wants to merge 1 commit into
Open
Frank-zhu0404 wants to merge 1 commit into
Frank-zhu0404 wants to merge 1 commit into
Conversation
Document that light-token overrides need :root[data-theme="light"], acknowledge plugin ui.theme contributions in the design-system non-goals, and fill base/assets/windowAppearance gaps in the plugin developer guide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:root[data-theme="light"](04-plugin-security§3.1 + plugin developer guide).ui.themecontributions (EN + zh-CN).plugin-development.md:basedefaultdark,assetswhitelist/4MB/plugin-asset:rewrite, andwindowAppearance(#rrggbb/#rrggbbaa, needsui.window.appearance), with links to the manifest schema.Closes #343
Test plan
tokens.css/ hellomidnight.csscommentsui.theme