Skip to content

fix(rpc): 清掉剩余 readline NDJSON 读口 - #559

Merged
vastsa merged 1 commit into
mainfrom
fix/ndjson-readline-followup
Sep 17, 2026
Merged

vastsa merged 1 commit into
mainfrom
fix/ndjson-readline-followup

Conversation

@vastsa

@vastsa vastsa commented Sep 17, 2026

Copy link
Copy Markdown
Owner

问题与修复

Follow-up after #557 / #548.

#553 已合入生产 RPC 读口。审查残留:

  • Codex JSONL 扫描仍用 readline,含 U+2028/U+2029 的会话标题会被拆行
  • e2e host harness(smoke / market / sidecar models)同样用 readline 读 host/sidecar stdout
  • shared 单测的假流不走 Node setEncoding,去不掉 setEncoding 也能绿

本次改为全部走 readNdjsonLines,并补上 PassThrough 逐字节切分与 Codex 扫描回归。契约测试同时禁止 createInterface

验证

  • shared ndjson 5/5
  • desktop rpc-lifecycle / ndjson-stream / importer-codex-scan 27/27
  • pnpm test:e2e:rpc-unicode 通过

Switch Codex JSONL scanning and the e2e host harnesses off Node
readline so U+2028/U+2029 stay inside a frame. Cover real Node
setEncoding splits and lock createInterface out of the transport
readers.
Copilot AI lite review requested due to automatic review settings September 17, 2026 17:41

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vastsa
vastsa merged commit 8db34e1 into main Sep 17, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants