fix(rpc): 清掉剩余 readline NDJSON 读口 - #559
Merged
Merged
Conversation
Switch Codex JSONL scanning and the e2e host harnesses off Node readline so U+2028/U+2029 stay inside a frame. Cover real Node setEncoding splits and lock createInterface out of the transport readers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题与修复
Follow-up after #557 / #548.
#553 已合入生产 RPC 读口。审查残留:
readline,含 U+2028/U+2029 的会话标题会被拆行readline读 host/sidecar stdoutsetEncoding,去不掉setEncoding也能绿本次改为全部走
readNdjsonLines,并补上 PassThrough 逐字节切分与 Codex 扫描回归。契约测试同时禁止createInterface。验证
pnpm test:e2e:rpc-unicode通过