refactor(settings): 字体选择器触发器并入语言/主题共享样式 - #577
Merged
Merged
Conversation
Fold the font pill into the shared Appearance picker rules so hug-width and hover cannot drift, and search the localized system-default label plus the English catalog name through one haystack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
#565 合入后，字体 pill 的 hug 宽度规则仍是一份独立拷贝，和语言 / 主题 /
SettingsMenuSelect会漂移。默认项搜索 haystack 对非 default 项有冗余 OR。改动
.settings-font*触发器规则并入 Appearance 共享选择器列表。${localized} ${catalog}。验证
node --test apps/desktop/test/settings-font-picker.test.mjs apps/desktop/test/settings-general.test.mjs apps/desktop/test/settings-language-picker.test.mjs apps/desktop/test/settings-theme-picker.test.mjs— 35/35未跑
verify:ui:*（本任务未要求）。未改链接打开目标。Follow-up of #565.