fix(plugins): migrate generated imported main.js wrappers on load - #598
Merged
Merged
Conversation
Existing imported ESM packages still fail after the main.cjs generator fix. Rewrite the generated no-op in place when the plugin loads, and leave customized main.js and copied package files untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #540 / #506.
New imports already generate
main.cjs. Existing imported ESM packages still fail on load because their generated CommonJSmain.jsis treated as ESM. Loading animported.*plugin now rewrites that generated no-op in place tomain.cjsand updates the manifest.Copied
package.jsonfiles, grants, and activation scope are unchanged. A customizedmain.jsis not rewritten. Re-import without removal still creates a separate plugin.Test
node --test apps/desktop/test/imported-package-skills-runtime.test.mjs apps/desktop/test/agent-extensions.test.mjs— 25 passed.