Sourcery Starbot ⭐ refactored vbrozik/fortigate2csv

[SourceryAI]

Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨

Here's your pull request refactoring your most popular Python repo.

If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch https://github.com/sourcery-ai-bot/fortigate2csv master
git merge --ff-only FETCH_HEAD
git reset HEAD^

[SourceryAI]

Function build_csv refactored with the following changes:

• Merge else clause's nested if statement into elif (merge-else-if-into-elif)
• Hoist for/while loops out of nested conditionals (hoist-loop-from-if)

This removes the following comments ( why? ):

# parse list, extract q_origin_key for each item within the field
# this field is just a string/int, simply add it to the row

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 1.26%.

Quality metrics	Before	After	Change
Complexity	32.23 😞	25.80 😞	-6.43 👍
Method Length	202.00 😞	201.00 😞	-1.00 👍
Working memory	15.19 ⛔	15.27 ⛔	0.08 👎
Quality	26.79% 😞	28.05% 😞	1.26% 👍

Other metrics	Before	After	Change
Lines	351	346	-5

Changed files	Quality Before	Quality After	Quality Change
fortigate2csv.py	26.79% 😞	28.05% 😞	1.26% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
fortigate2csv.py	main	29 😞	662 ⛔	18 ⛔	15.60% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
fortigate2csv.py	build_csv	37 ⛔	177 😞	13 😞	28.29% 😞	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
fortigate2csv.py	f_login	5 ⭐	124 😞	11 😞	59.03% 🙂	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!