[vdemonchy]

What

Two changes to the controller lighting, across the daemon and all three frontends.

"Control lighting" → "Enable lighting", and off now means off

The toggle used to mean "the daemon doesn't touch the LEDs", which left the controller running its firmware animation with no way to stop it from the UI. It now controls the lighting: on lights the LEDs from the saved settings, off blanks all four zones. The colour controls only exist while lighting is on — there is nothing to configure when the LEDs are off.

The frontends therefore always emit the rgb block now, carrying an enabled flag. A config.json with no rgb block at all still leaves the lighting untouched, so CLI-only setups are unaffected.

Note

Behaviour change for existing users: the toggle defaults to off, so the first run after upgrading blanks the LEDs instead of leaving the firmware animation running.

New "Logo shows battery level" option

Hands the Logo zone to the daemon, which colours it green / yellow / red from the battery percentage using the same thresholds that tint the tray icon (now written to config.json as level_high / level_low). The other three zones keep their configured colours, and the logo falls back to its configured colour whenever the level is unknown — absent, no battery source, or stale — rather than claiming a level the daemon can't vouch for.

How

The daemon re-applies lighting on every poll so the logo can track the level. rgbFrames is a delta against what was last pushed: unchanged lighting sends zero frames and never opens the hidraw node, and a battery band change sends exactly one zone write, with no enter-static flash. State is committed only after every frame is written, so a partial write retries the whole sequence.

config.RGB gains enabled (a *bool, so a config written before this key existed still counts as enabled), battery_logo, level_high and level_low.

Incidental fix

Adding rgb_battery_logo surfaced a config-loading bug in the COSMIC applet: cosmic-config's get_entry returns Err when any key is missing from the stored config, and init discarded the partial config that comes back with it. Any new key would therefore have reset every saved setting on first launch. The partial config is now kept, so only genuinely missing keys fall back to their defaults.

Testing

• New rgbFrames tests cover the delta writes, the disabled-blanking, the threshold mapping, the unknown-level fallback and the missing-enabled back-compat path. Go suite and the applet's cargo test pass.
• Installed on a live COSMIC session: config.json round-trips through the new shape with the saved settings intact.
• Confirmed on the controller in XInput mode — toggling off blanks the zones, toggling on restores them, and the logo tracks the battery band.

GNOME and KDE carry the same two options and the same gating, but were not exercised on a live session.

🤖 Generated with Claude Code