feat(host_metrics source): add ROOTFS_ROOT support#25880
Open
fpytloun wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
@pront Hello, can this small change be merged? It solves use-case when vector is running in Docker container with rootfs mounted on eg. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds documented Unix-only ROOTFS_ROOT support to the host_metrics filesystem collector. When set, Vector resolves filesystem capacity and inode reads through the mounted host root while preserving logical mountpoint labels.
The existing PROCFS_ROOT and SYSFS_ROOT startup handling now also treats empty values as unset. Filesystem usage errors include both logical and resolved mount paths.
Vector configuration
Run with ROOTFS_ROOT=/mnt/host and mount the host root read-only at /mnt/host.
How did you test this PR?
Focused Clippy was attempted but is blocked by a pre-existing lint under the locally installed Rust 1.96 toolchain: src/config/loading/secret.rs:151 triggers clippy::manual_option_zip. The repository pins Rust 1.95.
Change Type
Is this a breaking change?
Does this PR include user facing changes?
References