fix(tests): make mock retain extraction deterministic#1220
Draft
JulienJBO wants to merge 1 commit intovectorize-io:mainfrom
Draft
fix(tests): make mock retain extraction deterministic#1220JulienJBO wants to merge 1 commit intovectorize-io:mainfrom
JulienJBO wants to merge 1 commit intovectorize-io:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scope=retain_extract_factsmemorytest fixture to the mock provider when no local LLM env is configuredWhy
Running
hindsight-api-slimtests locally without a populated.envcurrently falls back to a real provider (groq) and fails early, or, when forced tomock, retain-heavy integration tests extract zero facts and produce large misleading failure clusters. This keeps the generic mock behavior intact while making local retain/recall integration tests deterministic and useful.Validation
uv run pytest tests/test_per_operation_llm_config.py::TestMockLLMProvider::test_mock_provider_generates_facts_for_retain_extract_scope -quv run pytest tests/test_retain_append_mode.py::test_append_mode_concatenates_content -quv run pytest tests/test_tags_visibility.py -quv run ruff check hindsight_api/engine/providers/mock_llm.py tests/conftest.py tests/test_per_operation_llm_config.pyFollow-up
A broader local no-env test pass still has a second cluster around richer mock behaviors (
consolidation,causal_relations,entity_labels, and zero-fact edge cases). I kept this PR scoped to the first large retain/recall failure wave.