fix(embed): preserve profile HINDSIGHT guardrails#1257
Open
grabyourfiles wants to merge 1 commit intovectorize-io:mainfrom
Open
fix(embed): preserve profile HINDSIGHT guardrails#1257grabyourfiles wants to merge 1 commit intovectorize-io:mainfrom
grabyourfiles wants to merge 1 commit intovectorize-io:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.envbefore daemon already-running short-circuitsHINDSIGHT_*keys during profile registration, includingHINDSIGHT_EMBED_*daemon guardrailsHINDSIGHT_EMBED_DAEMON_IDLE_TIMEOUTand consolidation env preservationtyfalse positives for Windows-onlysubprocessconstantsWhy
hindsight-embed -p <profile> daemon startcan re-register profile metadata even when a daemon is already running. Passing only the caller-provided config to registration can silently erase persisted profile guardrails such asHINDSIGHT_EMBED_DAEMON_IDLE_TIMEOUT=0or consolidation token limits.Test plan
cd hindsight-embed && uv run ruff check hindsight_embed/daemon_embed_manager.py tests/test_profile_daemon_config.pycd hindsight-embed && uv run pytest tests/test_profile_daemon_config.py -qcd hindsight-embed && uv run pytest tests -qcd hindsight-embed && uv run ty check hindsight_embed/daemon_embed_manager.py tests/test_profile_daemon_config.py