Add option to disable HFI when stopped in duty cycle and speed modes#86
Add option to disable HFI when stopped in duty cycle and speed modes#86lgeek wants to merge 1 commit intovedderb:masterfrom
Conversation
This introduces the HFI "Min ERPM with no input" option for firmware 5.02. This option dynamically disables HFI in the duty cycle or speed modes when 0 duty cycle / speed is commanded and the ERPM of the motor is lower than the set value.
|
it looks like there is a lot of extra changes in the files for this pr than just adding the required settings. |
|
Yeah, the slowness in reviewing pull requests has not been great. I'm trying to help with that by reviewing what I can and bumping things along so they are in a form that's ready to merge. If you still feel this feature is worth adding, Updating this to master and making sure it can be pulled in cleanly would be helpful. (The bldc FW PR too) github shows a diff of adding completely new config xml's. which is not ideal. For adding parameters, I would expect only chunks of additions in res/config/6.00/parameters_mcconf.xml (you use the parameter editor to overwrite the current development xml. Then I recommend checking the diff in git to make sure it's reasonable.) Also, for simple parameters, vedder will sometimes do the parameter adding for you on the vesc_tool side since it's easy for him. Though a pull request is appreciated. |
This introduces the HFI "Min ERPM with no input" option for firmware 5.02.
This option dynamically disables HFI in the duty cycle or speed modes
when 0 duty cycle / speed is commanded and the ERPM of the motor is lower
than the set value.
Matching firmware pull request here: vedderb/bldc#183