feat: add webpack arg for customizing webpack config#1155
Open
iamhollow wants to merge 3 commits intovercel:mainfrom
Open
feat: add webpack arg for customizing webpack config#1155iamhollow wants to merge 3 commits intovercel:mainfrom
webpack arg for customizing webpack config#1155iamhollow wants to merge 3 commits intovercel:mainfrom
Conversation
iamhollow
force-pushed
the
ncc-extend-webpack-config
branch
from
831ac7f to
40376d0
Compare
styfle
requested changes
Jan 29, 2024
Member
styfle
left a comment
styfle
left a comment
There was a problem hiding this comment.
Thanks for the PR!
We don't want to expose anything specific to webpack because that will make it much harder to swap webpack to another bundler (such as turbopack) in the future.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the base ncc webpack config to be customized or extended, similar to NextJS:
https://nextjs.org/docs/app/api-reference/next-config-js/webpack
The use cases of this feature are scenarios such as adding additional webpack rules or plugins, or configuring a path resolve alias.
The README has been updated for the programmatic invoke from Node.js to include the new
webpackarg.