fix: make sourcemap base prefix relative from outdir to the build file instead of static "../" (fixes #1253)

[iamstarkov]

should address issue described in #1253

I was also thinking to expose sourcemap base prefix as an ncc argument in case there are more bugs or edge cases and some people will require manual adjustment, but decided to start small

[styfle]

Thanks, can you add a test to confirm this works?

[iamstarkov]

Thanks, can you add a test to confirm this works?

Yes, I'll give it a try

[iamstarkov]

@styfle added relevant tests

3 unrelated integration tests fail for me locally both in my branch and in up to date main branch.

These are the tests and corresponding errors:

• should execute "ncc run aws-sdk.js": Error: Cannot find module '@aws-sdk/client-s3'
• should execute "ncc run binary-require.js": Error: Cannot find module './hello.node'
• should execute "ncc run canvas.js": Error: Cannot find module '../build/Release/canvas.node'

I assume its because npm run build-test-binary fails due to missing distutils, which had been fixed in node-gyp 10, while ncc uses 9

[iamstarkov]

how does it look?

[styfle]

Thanks for the PR!

Looks like tests are failing CI though.

Were you able to get tests passing locally?

[iamstarkov]

Thanks for the PR!

Looks like tests are failing CI though.

Were you able to get tests passing locally?

last time around all but few unrelated tests were passing, see more in the prev comment #1254 (comment)

let me check now

[iamstarkov]

I believe the test dont work no more, because suggested change broke them =)

[styfle]

I see. I guess we can try the old code but it didn't seem right. Would't it trim the wrong character if it didn't end with a /? 🤔

[iamstarkov]

yes, probably. but I think this thing is a crutch. we should adjust webpack configuration so it generates sourcemaps relative to the source to begin with

[iamstarkov]

I gonna give it a go