fix(eslint-plugin-next): respect pageExtensions in no-html-link-for-pages (#53473) - #96993
Open
arts009009009 wants to merge 1 commit into
Open
fix(eslint-plugin-next): respect pageExtensions in no-html-link-for-pages (#53473)#96993arts009009009 wants to merge 1 commit into
arts009009009 wants to merge 1 commit into
Conversation
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| type: 'string', | ||
| }, | ||
| { | ||
| type: 'object', |
Contributor
There was a problem hiding this comment.
The no-html-link-for-pages rule's option schema was narrowed to object-only, so ESLint schema validation rejects the previously-supported string and array-of-strings options before create() runs, throwing an "invalid configuration" error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ESLint rule
@next/next/no-html-link-for-pageswas ignoring files with custom extensions (e.g..page.tsx) whenpageExtensionswas configured. This PR updates the rule to correctly respect thepageExtensionsoption.Reproduction
.eslintrc.cjswithpageExtensions: ["page.tsx"]tests/pageExtensions/about.page.tsxImplementation
no-html-link-for-pages.tsto checkpageExtensions.tests/pageExtensionsto confirm behavior.Tests
.page.tsxfiles are now linted..js/.jsx/.ts/.tsxextensions remains unchanged.Closes #53473