celery: shard subscriber functions per derived config - #316
Open
nsidnev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the Celery adapter respect
max_durationfor subscriber functions and shard queue topics, so that tasks with different hardtime_limitvalues are deployed as separate functions with the appropriatemaxDuration. Tasks without an explicit limit stay on the queue's base topic, whose limit comes from the newmax_durationentry inbroker_transport_optionsor the app'stask_time_limitsetting.Registration now finalizes the app first, because task declarations on an unfinalized app are still pending decorators, so reading them earlier would silently register no shards and Celery's finalize hooks run in nondeterministic order, so registration is deferred to
on_after_finalize, when all tasks are known.Like the Dramatiq adapter and the SDK,
time_limitvalues above 30 minutes are capped with a warning instead of an error so user code remains deployable.