Skip to content

fix(web-shared): match Attributes section spacing to Metadata #2949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mitul-s wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −3
Draft

fix(web-shared): match Attributes section spacing to Metadata #2949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/attributes-metadata-spacing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@workflow/web-shared': patch
---

Match Attributes (and hook Metadata) section content spacing to the top Metadata panel.
6 changes: 3 additions & 3 deletions packages/web-shared/src/components/sidebar/attributes-block.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ export function RunAttributesCard({
return (
<CollapsibleRoot defaultOpen>
<CollapsibleTrigger>Attributes</CollapsibleTrigger>
<CollapsibleContent className="mb-4">
<CollapsibleContent className="mt-0 mb-2">
<div className="flex flex-col">
{keys.map((key) => (
<AttributeRow
Expand Down Expand Up @@ -228,7 +228,7 @@ export function RunMetadataCard({ metadata }: { metadata: unknown }) {
return (
<CollapsibleRoot defaultOpen>
<CollapsibleTrigger>Metadata</CollapsibleTrigger>
<CollapsibleContent className="mb-4">
<CollapsibleContent className="mt-0 mb-2">
<CopyableDataBlock data={metadata} />
</CollapsibleContent>
</CollapsibleRoot>
Expand All @@ -241,7 +241,7 @@ export function RunMetadataCard({ metadata }: { metadata: unknown }) {
return (
<CollapsibleRoot defaultOpen>
<CollapsibleTrigger>Metadata</CollapsibleTrigger>
<CollapsibleContent className="mb-4">
<CollapsibleContent className="mt-0 mb-2">
<div className="flex flex-col">
{keys.map((key) => (
<AttributeRow
Expand Down
Loading