Backport #2963: Fix dotted tsconfig alias workflow discovery#2982
Open
github-actions[bot] wants to merge 1 commit into
Open
Backport #2963: Fix dotted tsconfig alias workflow discovery#2982github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
* Fix dotted alias workflow discovery * Increase streamer stress test cleanup timeout * Increase canary HMR rediscovery timeout Signed-off-by: Nathan Colosimo <110621881+NathanColosimo@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 7482bba The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| ); | ||
|
|
||
| expect(discovered.discoveredWorkflows).toEqual(new Set()); | ||
| expect(discovered.discoveredFiles).toEqual(new Set([normalize(entryFile)])); |
Contributor
There was a problem hiding this comment.
Suggested change
| expect(discovered.discoveredFiles).toEqual(new Set([normalize(entryFile)])); |
Test references non-existent discovered.discoveredFiles property, causing tsc (TS2551) to fail and breaking @workflow/builders#build and downstream Vercel builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated backport of #2963 to
stable(backport job run).AI recommendation: This is a self-contained bug fix to
fast-discovery.ts(the buggyshouldSkipFastDiscoveryImportfunction verified to exist onstable), fixingWorkflowNotRegisteredErrorfor dotted tsconfig-aliased imports. The accompanying test additions and Windows cleanup-timeout hardening all touch files present and maintained onstable, and none of the changes depend onmain-only APIs.Merge conflicts were resolved by AI (opencode with
anthropic/claude-opus-4.8). Please review the conflict resolution carefully before merging.