Remove unused OptionT.run simp argument in three WP lemmas#7
Open
astefano wants to merge 1 commit into
Open
Conversation
`linter.unusedSimpArgs` flags `OptionT.run` as unused in `tryCatch_OptionT_wp`, `monadLift_OptionT_wp`, and `orElse_OptionT_wp`: the projection is already discharged by the surrounding lemmas, so the argument never fires. The `OptionT.run` at L362 is used and left in place. Closes verse-lab#6 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linter.unusedSimpArgs(default-on, Lean core) flagsOptionT.runas an unusedsimp onlyargument intryCatch_OptionT_wp(L217),monadLift_OptionT_wp(L319), andorElse_OptionT_wp(L679) ofLoom/WP/Lemmas.lean. The projection is already discharged by the surrounding lemmas (OptionT.mketc.), so the argument never fires; removing it leaves the proofs unchanged. This PR does this.Verified on the
v4.29.0toolchain (used by thequangvdao/loom2fork and downstream VCVio): the three lemmas compile cleanly with the warning gone. TheOptionT.runat L362 is used and left in place.Closes #6.