Repository navigation
Closed
Labels
bugSomething isn't workingSomething isn't workingdocumentationImprovements or additions to documentationImprovements or additions to documentation
Description
Version
vfox-java main (bfcdbcc), vfox 1.0.13
OS
Windows
Describe the bug
docs/e2e.md says the Windows latest combinations still run with an unspaced VFOX_HOME, because only vfox main carried version-fox/vfox#712:
Lines 193 to 198 in bfcdbcc
| The `main` combos run with `VFOX_HOME` pointing inside a path containing a | |
| space (`C:\Users\John Doe\.vfox`), mirroring | |
| [vfox-flutter#33](https://github.com/version-fox/vfox-flutter/issues/33). | |
| Only vfox `main` carries the fix for such paths | |
| ([vfox#712](https://github.com/version-fox/vfox/pull/712)), so `latest` | |
| combinations still run with an unspaced home. |
Since #82, every combination runs with C:\Users\John Doe\.vfox, as vfox 1.0.13 carries that fix too:
vfox-java/tests/e2e/windows/setup.go
Lines 68 to 79 in bfcdbcc
| // setupSlotEnv isolates the combo: USERPROFILE/TEMP/TMP point under | |
| // vfox-e2e-runs\<slot>, while VFOX_HOME is spacedVfoxHome. Each combo runs in | |
| // its own container, so the shared VFOX_HOME never leaks between combos. Both | |
| // vfox main and releases since v1.0.13 handle a home containing a space | |
| // (https://github.com/version-fox/vfox/pull/712). | |
| func setupSlotEnv(ctx context.Context, t *testing.T, ctr tc.Container, slot string) slotBox { | |
| t.Helper() | |
| userProfile := strings.TrimSpace(execOK(ctx, t, ctr, "$env:USERPROFILE")) | |
| containerPath := strings.TrimSpace(execOK(ctx, t, ctr, "$env:PATH")) | |
| procArch := strings.TrimSpace(execOK(ctx, t, ctr, "$env:PROCESSOR_ARCHITECTURE")) | |
| home := spacedVfoxHome |
vfox-java/tests/e2e/windows/e2e_test.go
Lines 191 to 195 in bfcdbcc
| // runOne starts one long-lived container per combo and drives the whole | |
| // E2E flow (setup -> install -> verify) through pwsh exec calls, asserting | |
| // in Go. A combo passes when every phase exits 0 and the outputs carry the | |
| // expected markers. Every combo runs against a VFOX_HOME containing a | |
| // space (see spacedVfoxHome). |
#82 changed only the suite (tests/e2e/windows/), so the paragraph still describes the setup before it.
Found while working on #86.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingdocumentationImprovements or additions to documentationImprovements or additions to documentation
Activity
linghengqian commentedon Oct 17, 2026
I am working on the current issue.