Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 17, 2025

Setting VFOX_NODEJS_MIRROR=https://nodejs.org/dist/ (with trailing slash) produced invalid URLs like https://nodejs.org/dist//v22.18.0/.

Changes

  • lib/util.lua: Strip trailing slash from mirror URL in getBaseUrl() using gsub("/$", "")
  • README.md: Document that trailing slashes are automatically handled
-- Before
return mirror

-- After
return mirror:gsub("/$", "")

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • esm.ubuntu.com
    • Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

VFOX_NODEJS_MIRROR https://nodejs.org/dist/ 会导致拼出来的路径无法请求:
https://nodejs.org/dist//v22.18.0/

记得把文档什么的都更新一下


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: bytemain <13938334+bytemain@users.noreply.github.com>
@bytemain bytemain marked this pull request as ready for review December 17, 2025 09:44
Copilot AI changed the title [WIP] Fix path request issue for nodejs mirror Fix trailing slash in VFOX_NODEJS_MIRROR causing double slashes in URL paths Dec 17, 2025
Copilot AI requested a review from bytemain December 17, 2025 09:45
@bytemain bytemain merged commit ebb2be6 into main Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants