Configure kube-reserved cgroup#169
Open
Mathieu Parent (sathieu) wants to merge 1 commit into
Open
Conversation
References: - https://kubernetes.io/docs/tasks/administer-cluster/reserve-compute-resources/ - https://github.com/kubernetes/design-proposals-archive/blob/main/node/node-allocatable.md#recommended-cgroups-setup - https://soc.meschbach.com/posts/2022/07/30-cgroups-kubernetes-and-reliable-nodes/ Signed-off-by: Mathieu Parent <math.parent@etik.com>
Mathieu Parent (sathieu)
force-pushed
the
kube-reserved
branch
from
0ab53dd to
b372006
Compare
There was a problem hiding this comment.
Pull request overview
This PR introduces a dedicated systemd slice (podruntime.slice) and moves kubelet + containerd into it as groundwork for Kubernetes “node allocatable / reserved resources” cgroup layouts.
Changes:
- Add a new
podruntime.sliceunit and element to provide a named cgroup/slice for node runtime services. - Configure
kubelet.serviceandcontainerd.serviceto run underpodruntime.slice. - Add element dependency wiring so the slice unit is present when kubelet/containerd are installed.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| elements/podruntime-slice/init-scripts/systemd/podruntime.slice | Adds a new systemd slice unit definition for podruntime.slice. |
| elements/podruntime-slice/element-deps | Declares init-system dependency for installing the slice unit. |
| elements/kubelet/init-scripts/systemd/kubelet.service | Assigns kubelet to podruntime.slice. |
| elements/kubelet/element-deps | Ensures kubelet element pulls in the slice element. |
| elements/containerd/init-scripts/systemd/containerd.service | Assigns containerd to podruntime.slice. |
| elements/containerd/element-deps | Ensures containerd element pulls in the slice element. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,7 @@ | |||
| [Unit] | |||
| Description=Limited resources slice for Kubernetes services | |||
Contributor
Author
There was a problem hiding this comment.
I think the unit should be created, at least for DefaultDependencies=no
Contributor
Author
|
Can someone review my PR? 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References:
What is missing:
kubeReservedCgroup: /podruntime.sliceis not set, because this should go in KubeletConfiguration IMO