Conversation
Update trivially_serializable.cpp
Co-authored-by: Adam Novak <anovak@soe.ucsc.edu> Assisted-by: Claude Code:claude-sonnet-5
Add HANDLEGRAPH_USE_EXCEPTIONS (default ON, matches current behavior) and HANDLEGRAPH_USE_ABSEIL_LOGGING (default OFF) CMake options. With exceptions off, fatal errors go through ABSL_LOG(FATAL) if Abseil logging is enabled, or stderr + std::abort() otherwise. Needed to build libhandlegraph into exceptions-free Bazel binaries such as DeepVariant. Co-authored-by: Adam Novak <anovak@soe.ucsc.edu> Assisted-by: Claude Code:claude-sonnet-5
…ucted exception Co-authored-by: Adam Novak <anovak@soe.ucsc.edu> Assisted-by: claude-code:claude-sonnet-5
Co-authored-by: Adam Novak <anovak@soe.ucsc.edu> Assisted-by: claude-code:claude-sonnet-5
Assisted-by: Claude:claude-sonnet-5 Co-authored-by: Adam Novak <anovak@soe.ucsc.edu>
…ns directly Assisted-by: Claude:claude-sonnet-5 Co-authored-by: Adam Novak <anovak@soe.ucsc.edu>
Assisted-by: Claude:claude-sonnet-5 Co-authored-by: Adam Novak <anovak@soe.ucsc.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings in the changes @mobinasri made for pangenome-aware DeepVariant and tries to put particularly Googley ones (like not throwing exceptions) behind build flags.
Much of the work here is synthetic, so I need to review it before anyone else looks at it.
This is related to vgteam/sdsl-lite#21